test: refactor outcomes to helper assertion

Since each time we're asserting the output of the test as well as the
test outcome, we can clarify the fields of `parse_outcomes` in one
place.

Signed-off-by: Mike Fiedler <[email protected]>

tests/test_socket.py

@@ -21,6 +21,7 @@ def reenable_socket():
 
 
 def assert_socket_blocked(result):
+ result.assert_outcomes(passed=0, skipped=0, failed=1)
  result.stdout.fnmatch_lines("""
  *SocketBlockedError: A test tried to use socket.socket.*
  """)
@@ -48,14 +49,12 @@ def test_socket():
  socket.socket(socket.AF_INET, socket.SOCK_STREAM)
  """)
  result = testdir.runpytest("--verbose")
- result.assert_outcomes(0, 0, 1)
  assert_socket_blocked(result)
 
 
 def test_global_disable_via_cli_flag(testdir):
  testdir.makepyfile(PYFILE_SOCKET_USED_IN_TEST)
  result = testdir.runpytest("--verbose", "--disable-socket")
- result.assert_outcomes(0, 0, 1)
  assert_socket_blocked(result)
 
 
@@ -76,7 +75,6 @@ def test_global_disable_via_config(testdir):
  addopts = --disable-socket
  """)
  result = testdir.runpytest("--verbose")
- result.assert_outcomes(0, 0, 1)
  assert_socket_blocked(result)
 
 
@@ -90,7 +88,6 @@ def test_socket():
  socket.socket(socket.AF_INET, socket.SOCK_STREAM)
  """)
  result = testdir.runpytest("--verbose")
- result.assert_outcomes(0, 0, 1)
  assert_socket_blocked(result)
 
 
@@ -104,7 +101,6 @@ def test_socket():
  socket.socket(socket.AF_INET, socket.SOCK_STREAM)
  """)
  result = testdir.runpytest("--verbose", "--disable-socket")
- result.assert_outcomes(0, 0, 1)
  assert_socket_blocked(result)
 
 
@@ -136,7 +132,6 @@ def test_disable_socket_urllib():
  assert urlopen('http:https://httpbin.org/get').getcode() == 200
  """)
  result = testdir.runpytest("--verbose", "--disable-socket")
- result.assert_outcomes(0, 0, 1)
  assert_socket_blocked(result)
 
 
@@ -153,7 +148,6 @@ def test_disable_socket_urllib():
  assert urlopen('http:https://httpbin.org/get').getcode() == 200
  """)
  result = testdir.runpytest("--verbose")
- result.assert_outcomes(0, 0, 1)
  assert_socket_blocked(result)