Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sometimes feature including tests #129

Merged
merged 2 commits into from
Sep 19, 2016
Merged

add sometimes feature including tests #129

merged 2 commits into from
Sep 19, 2016

Conversation

richriscunha
Copy link
Contributor

#69

@iamdtang
Copy link
Collaborator

on vacation. will check this in a week.

@garygreen
Copy link
Collaborator

@richriscunha thanks for this PR. Just one thing, could you also add the:

if (this._passesOptionalCheck(attributeRules) && !(this._suppliedWithData(attribute))) { continue; }

to the checkAsync method as well? Bit funny that there are two check methods but one is to handle async-based validation.

@richriscunha
Copy link
Contributor Author

Sure, I'm traveling on business now. So, I won't get to it until at least the middle to end of the week. But, if I can get to it sooner, I will.

@richriscunha
Copy link
Contributor Author

@garygreen I've added the additional check to the checkAsync method now too. In addition, I've added a couple of more test specs to cover checkAsync using the sometimes rule too.

@garygreen garygreen merged commit 61cee9a into mikeerickson:master Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants