Update URL whenever prices are filled

[axismb]

Not sure if its useful for others but I've had this issue on desktop & know at least one other friend with it too.

Basically, when you're tabbing through inputs and copy the URL from the url bar of your browser, the URL ends up being stale unless you explicitly click the Copy Permalink button. This fork automatically updates the url as you update it so you can easily Cmd/Ctrl + L and copy paste.

[peter50216]

Should this only updates the URL if the original prices comes from URL parameters?

Currently localstorage is disabled while there are parameters from the URL, so clicking random links won't accidentally override user's local data. Would this change causes that localstorage is not used most of the time?

[peter50216]

I'd use a simple if to be consistent with other parts of the code.

[axismb]

Should this only updates the URL if the original prices comes from URL parameters?

Currently localstorage is disabled while there are parameters from the URL, so clicking random links won't accidentally override user's local data. Would this change causes that localstorage is not used most of the time?

I think, from the testing I did, this does not change that behavior, on a clean localstorage, I was able to confirm loading a url with a query param did not set localstorage (it set populated_from_query = true) and changing the inputs which in turn update did not update localstorage either.

However if I load the url without any query params, it loads from localstorage then updates the query params.

Let me know if this makes sense or if I should test more cases.

[peter50216]

Should this only updates the URL if the original prices comes from URL parameters?
Currently localstorage is disabled while there are parameters from the URL, so clicking random links won't accidentally override user's local data. Would this change causes that localstorage is not used most of the time?

I think, from the testing I did, this does not change that behavior, on a clean localstorage, I was able to confirm loading a url with a query param did not set localstorage (it set populated_from_query = true) and changing the inputs which in turn update did not update localstorage either.

However if I load the url without any query params, it loads from localstorage then updates the query params.

Let me know if this makes sense or if I should test more cases.

The case I'm curious on is loading the url without any query params, and then whether filling values updates localstorage (I'd guess so).

But there might be another unexpected behavior from user perspective:

• Navigates to the url without any query params, fill in some values.
• Reloads the page (can happen by e.g. restarting the browser)
• Fill in more values, which iiuc won't be saved to localstorage at this point after the change, since the URL is changed.
• Close the website and found out that some values are missing the next time the site is opened.

[axismb]

Should this only updates the URL if the original prices comes from URL parameters?
Currently localstorage is disabled while there are parameters from the URL, so clicking random links won't accidentally override user's local data. Would this change causes that localstorage is not used most of the time?

I think, from the testing I did, this does not change that behavior, on a clean localstorage, I was able to confirm loading a url with a query param did not set localstorage (it set populated_from_query = true) and changing the inputs which in turn update did not update localstorage either.
However if I load the url without any query params, it loads from localstorage then updates the query params.
Let me know if this makes sense or if I should test more cases.

The case I'm curious on is loading the url without any query params, and then whether filling values updates localstorage (I'd guess so).

But there might be another unexpected behavior from user perspective:

• Navigates to the url without any query params, fill in some values.
• Reloads the page (can happen by e.g. restarting the browser)
• Fill in more values, which iiuc won't be saved to localstorage at this point after the change, since the URL is changed.
• Close the website and found out that some values are missing the next time the site is opened.

Yep, the first case you mention works correctly. That's a good point about this edge case/behavior, I wonder if checking the values indexdb across what's in the query params is a good way to deal with that; e.g, if they're all the same, continue to update localstorage.