BugFix for View Laravel 5.6 & BugFix for becoming yourself #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 11, 2018 15:20
Impersonate destroy does not work for every user mikebronner#6
|
Hi @Nowi5 thanks for taking on this PR ... its been a while since I spent some time on this package, and it's not yet completely finished. I think I had most of the functionality in place, but needed to iron out some bugs and add tests. I'll take a look at your PR in the near future, I con't promise how soon, as I am very busy with some other work at the moment. Please do report any bugs, or better yet, submit PRs if you can fix them. :) Thanks! |
|
@Nowi5 Most items are implemented, thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Laravel 5.6 the view publish function has changed slightly, so adjusted the name it works again (without subfolder). In addition becoming yourself is now always possible.