Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reset.css #7

Merged
merged 1 commit into from
Jul 7, 2019
Merged

Update reset.css #7

merged 1 commit into from
Jul 7, 2019

Conversation

notiv-nt
Copy link
Contributor

@notiv-nt notiv-nt commented Jul 6, 2019

  1. Wrong https://jsfiddle.net/notiv/gyds6f5q/2/
html, body {
  height: 100%;
}

Screen Recording 2019-07-06 at 15 10 01 mov

  1. Right https://jsfiddle.net/notiv/tceofsgd/3/
html, body {
  min-height: 100%;
}

Screen Recording 2019-07-06 at 15 12 41 mov

@mike-engel
Copy link
Owner

Thanks a lot @notiv-nt! This is great.

@mike-engel mike-engel merged commit d29feb8 into mike-engel:master Jul 7, 2019
@mike-engel
Copy link
Owner

@all-contributors add @notiv-nt for code

@allcontributors
Copy link
Contributor

@mike-engel

I've put up a pull request to add @notiv-nt! 🎉

@mike-engel
Copy link
Owner

This is now available in 1.1.1 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants