Limit size of child to bounds of parent when applying visualPadding #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If child components have e.g. the
fillx
constraint and also visualPaddings specified the child may be layed out outside the parents bounds. This results in e.g. focus rings not be painted on those side.Here is a small example that demonstrated the problem:
Without the patch the magenta border will be invisible.
I am not fully sure it is the correct approach. Maybe there is some scenario where one would actually want a child to extend outside the parent. But I wasn't able to track down the code where
fill
constraints are evaluated to patch it at that point already.Any feedback is highly appreciated.