This repository has been archived by the owner on May 24, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing the size before this PR and after, it went:
Before
After
You can see from the original EIP that the
keccak
library is trusted by the Eth core devs and is a secure package: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-55.mdHere are the bundle size comparisons:
https://bundlephobia.com/package/[email protected]
https://bundlephobia.com/package/[email protected]
Test the size diff yourself
My VSCode bundle diff
(this is made possible with https://github.com/wix/import-cost)