Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Haml 6 support #84

Merged
merged 6 commits into from
Jan 18, 2024
Merged

Fix Haml 6 support #84

merged 6 commits into from
Jan 18, 2024

Conversation

markets
Copy link
Member

@markets markets commented Jan 18, 2024

It seems that changes from #82 are incomplete to fully support Haml 6, so this branch is intended to fix that.

@markets
Copy link
Member Author

markets commented Jan 18, 2024

Hello @amatsuda 👋🏼

Sorry for the ping 🙏🏼, but since you contributed recently to MM and you are a Haml maintainer, could you please help us with that? I'm trying to give this plugin Haml 6 support.

This is all the related code: https://github.com/middleman/middleman-syntax/blob/master/lib/middleman-syntax/haml_monkey_patch.rb.

@markets markets marked this pull request as ready for review January 18, 2024 15:55
@markets
Copy link
Member Author

markets commented Jan 18, 2024

Yay! Haml 5 and 6 working 🎉

@tdreyno This is ready for review 👀 and merge
@amatsuda I think I finally got it working, see this commit 140fd7b

@tdreyno tdreyno merged commit 3099653 into middleman:master Jan 18, 2024
7 checks passed
@amatsuda
Copy link

@markets Sorry for responding late, but yes, this patch looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants