Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #83940 #84414

Merged
merged 10 commits into from
Nov 12, 2019
Merged

Fix #83940 #84414

merged 10 commits into from
Nov 12, 2019

Conversation

hadzhiyski
Copy link
Contributor

Supported languages: de, en, es, fr, hu, it, pt-br, ru

This PR fixes #83940

Supported languages: de, en, es, fr, hu, it, pt-br, ru
@msftclas
Copy link

msftclas commented Nov 10, 2019

CLA assistant check
All CLA requirements met.

@jaqra
Copy link
Contributor

jaqra commented Nov 11, 2019

SourceFile=%1 Kaynak Dosyası

You can add

OpenWithCodeContextMeny=%1 İle Aç

But i am not sure which key must be set as shortkey

@hadzhiyski
Copy link
Contributor Author

SourceFile=%1 Kaynak Dosyası

You can add

OpenWithCodeContextMeny=%1 İle Aç

But i am not sure which key must be set as shortkey

Thanks. I will try to research what is the correct translation for all supported languages

@jaqra
Copy link
Contributor

jaqra commented Nov 11, 2019

It is correct. It is my main language. You can also see from

AddContextMenuFiles=Windows Gezgini bağlam menüsüne "%1 İle Aç" eylemini ekle

Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, like @jaqra mentions, please fix the encoding issues. 👍 Thanks for the PR!

@hadzhiyski
Copy link
Contributor Author

Translations are added for all supported languages and the encoding issues are fixed. Please review

Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hadzhiyski I still see a lot of changes which don't make sense. Are you maybe converting line endings?

@hadzhiyski
Copy link
Contributor Author

Is that what you mean? I deleted the empty lines on end of files, because that was the original look of the files. I added them now. Perhaps I do not have proper file formatting settings and I am really sorry about this and I will fix it. It is my first PR in vscode repository.

@joaomoreno
Copy link
Member

Not yet... Notice here, all these lines are marked as changed, yet there is no reason for you to have changed them. There must still be some line-ending/encoding change:

image

@joaomoreno joaomoreno added this to the November 2019 milestone Nov 12, 2019
@joaomoreno joaomoreno added install-update VS Code installation and upgrade system issues windows VS Code on Windows issues labels Nov 12, 2019
@joaomoreno joaomoreno merged commit 72da3e4 into microsoft:master Nov 12, 2019
@joaomoreno
Copy link
Member

Great job, thanks!

@hadzhiyski
Copy link
Contributor Author

Thank you all for the support

@hadzhiyski hadzhiyski deleted the vh/83940-open-with-i18n branch November 12, 2019 15:27
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
install-update VS Code installation and upgrade system issues windows VS Code on Windows issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Open with Code" context menu is not localized
4 participants