Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update touch bar icons #66966

Merged
merged 2 commits into from
Jan 23, 2019
Merged

Update touch bar icons #66966

merged 2 commits into from
Jan 23, 2019

Conversation

miguelsolorio
Copy link
Contributor

@miguelsolorio miguelsolorio commented Jan 23, 2019 •
edited
Loading

Fixes #66689

Based on Apple's guidelines for touch bar icons, they should not be taller than 44x44:

image

So I went through and cleaned up all of our icons to match those sizes:

image

image

image

@miguelsolorio miguelsolorio added the ux User experience issues label Jan 23, 2019
@miguelsolorio miguelsolorio added this to the December/January 2019 milestone Jan 23, 2019
@miguelsolorio miguelsolorio mentioned this pull request Jan 23, 2019
Merged
@miguelsolorio miguelsolorio self-assigned this Jan 23, 2019
@isidorn
Copy link
Contributor

isidorn commented Jan 23, 2019

@misolori Great work
@bpasero I can also review and test it via simluator if you are busy - let me know.

@bpasero bpasero merged commit cbbd49e into master Jan 23, 2019
@bpasero bpasero deleted the misolori/touchbar-icons branch January 23, 2019 10:33
@bpasero bpasero restored the misolori/touchbar-icons branch January 23, 2019 10:33
@bpasero
Copy link
Member

bpasero commented Jan 23, 2019

Awesome thanks!

@bpasero bpasero deleted the misolori/touchbar-icons branch January 23, 2019 14:02
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero Awaiting requested review from bpasero

Assignees

@bpasero bpasero

@miguelsolorio miguelsolorio

Labels
ux User experience issues
Projects
None yet
Milestone
December/January 2019
Development

Successfully merging this pull request may close these issues.

Insiders build - touchbar no longer shows debug actions
3 participants
@miguelsolorio @isidorn @bpasero