Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typings for Promise#finally #65059

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Add typings for Promise#finally #65059

merged 1 commit into from
Jan 23, 2019

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented Dec 14, 2018

This add Promise.finally types which Electron 3.0 supports. Holding back this since we aren't 100% sure yet that we stick to this version. @bpasero when do we have enough confidence?

@jrieken jrieken self-assigned this Dec 14, 2018
@jrieken jrieken added this to the January 2019 milestone Dec 14, 2018
@jrieken jrieken added the engineering VS Code - Build / issue tracking / etc. label Dec 14, 2018
@jrieken
Copy link
Member Author

jrieken commented Jan 21, 2019

@bpasero Will we stick with Electron 3.x? Is this PR save to be merged?

@bpasero
Copy link
Member

bpasero commented Jan 23, 2019

@jrieken yes, go for it.

@jrieken jrieken merged commit 02248a4 into master Jan 23, 2019
@jrieken jrieken deleted the joh/promise-finally branch January 23, 2019 17:14
@jrieken jrieken mentioned this pull request Jan 23, 2019
Closed
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jrieken jrieken

Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Milestone
December/January 2019
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrieken @bpasero