Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide icons when using no-icons class #61461

Merged
merged 2 commits into from
Oct 22, 2018
Merged

Conversation

ramya-rao-a
Copy link
Contributor

@ramya-rao-a ramya-rao-a commented Oct 22, 2018

This PR fixes #61459

The bug is a regression due to f13c8d1#diff-b1e324b56791c91ba94b301f2d739ea9

@jrieken Now that we use the icon-label to show the icons, what is the purpose of .icon now?

@jrieken
Copy link
Member

jrieken commented Oct 22, 2018

Now that we use the icon-label to show the icons, what is the purpose of .icon now?

Both are needed and still in use because of color boxes.

Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a copy of this fule

@ramya-rao-a
Copy link
Contributor Author

Thanks and Done.

@ramya-rao-a ramya-rao-a merged commit cfff694 into master Oct 22, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
@alexdima alexdima deleted the ramyar/suggest-no-icons branch June 30, 2020 06:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icons are back in the suggest widget used in Settings and Extensions search
2 participants