Introduce keywords for actions to filter on (for #4679) #5432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexandrudima maybe you could give me some feedback on eebd22d The motivation is to be able to provide an array of keywords when registering an editor action so that we have means to find the action in the command palette in addition to the label of the action. We can then pass in english (non translated) words to fix #4679 |
|
@bpasero just small suggestion, you can use |
bpasero
changed the title
|
👍 |
| if (!this.workbenchActions[descriptor.id]) { | ||
| this.workbenchActions[descriptor.id] = descriptor; | ||
| registerWorkbenchCommandFromAction(descriptor); | ||
|
|
||
| if (category) { | ||
| this.mapActionIdToCategory[descriptor.id] = category; | ||
| if (typeof categoryOrKeywords === 'string') { |
|
no unit tests? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.