feat: chat participation detection api #224651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyceerhl
force-pushed
the
dev/joyceerhl/retired-dolphin
branch
from
34f3ccf
to
067038b
Compare
roblourens
reviewed
Aug 2, 2024
| } | ||
|
|
||
| async detectAgentOrCommand(request: IChatAgentRequest, history: IChatAgentHistoryEntry[], options: { location: ChatAgentLocation }, token: CancellationToken): Promise<{ agent: IChatAgentData; command?: IChatAgentCommand } | undefined> { | ||
| // TODO@joyceerhl should we have a selector to be able to narrow down which provider to use |
There was a problem hiding this comment.
I think it's fine to assume that there will only ever be one, this is probably only private API for us.
roblourens
reviewed
Aug 2, 2024
| @@ -245,6 +245,23 @@ declare module 'vscode' { | |||
| * The chat extension should not activate if it doesn't support the current version. | |||
| */ | |||
| export const _version: 1 | number; | |||
|
|
|||
| export function registerChatParticipantDetectionProvider(participantDetectionProvider: ChatParticipantDetectionProvider): Disposable; | |||
There was a problem hiding this comment.
Another idea I just thought of is that this would make sense on the default participant, like welcomeMessageProvider etc, but I think this shape is fine too.
roblourens
previously approved these changes
Aug 2, 2024
meganrogge
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.