Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: merge same namespace declaration #219638

Merged

Conversation

Cecil0o0
Copy link
Contributor

@Cecil0o0 Cecil0o0 commented Jul 2, 2024

export same two namespace in a module seems to be mis-understanding while contributors reading this module, this pr would like to solve this.

@Cecil0o0
Copy link
Contributor Author

Cecil0o0 commented Jul 2, 2024

@microsoft-github-policy-service agree

@mjbvz mjbvz assigned alexr00 and unassigned mjbvz Jul 2, 2024
@Cecil0o0 Cecil0o0 changed the title refactor: combine same namepsace declaration chore: merge same namespace declaration Jul 3, 2024
@alexr00 alexr00 assigned meganrogge and unassigned alexr00 Jul 4, 2024
@Cecil0o0 Cecil0o0 changed the title chore: merge same namespace declaration refactor: merge same namespace declaration Jul 22, 2024
@Cecil0o0
Copy link
Contributor Author

Cecil0o0 commented Jul 22, 2024

@meganrogge hi, could you have a look for this pr? ^_^

I used Bun.transpiler to transform this module in vscode codebase, and it will emit an error for duplicate namespace, while typescript could merge same namespace by it's compiler, not to emit error.

In my opinion, it could be better that we merge namespaces manually because of gaining better readability for this module, meanwhile, this pr will reduce possibility of emitting errors by some tools like Bun.transpiler.

@meganrogge
Copy link
Contributor

Hi @Cecil0o0 I'm not sure I understand the problem or what this PR does. Could you pls clarify in the description?

@Cecil0o0
Copy link
Contributor Author

Hi @Cecil0o0 I'm not sure I understand the problem or what this PR does. Could you pls clarify in the description?

Hi @meganrogge,

image

Here is background: I wrote a program to transform module code from vscode codebase, after I executed the program, got a error above.

when I saw this error, I opened the file with vscode, found two same namespace export which is Schemas. The first impression is wired about the code block. This pr solve the wired first impression when looking at this module.

@meganrogge meganrogge added this to the August 2024 milestone Jul 30, 2024
@Cecil0o0
Copy link
Contributor Author

Cecil0o0 commented Aug 1, 2024

@lramos15 Hi ^_^, could you please tell me why Monaco Editor checks action and Prevent yarn.lock changes in RPs action not run automatically, because these two actions would be expected, waiting for status to be reported. Is that something else I should do for that?

@meganrogge meganrogge merged commit d99c98b into microsoft:main Aug 1, 2024
6 checks passed
@Cecil0o0 Cecil0o0 deleted the refactor/combine-namespace-declaration branch August 2, 2024 04:32
BABA983 pushed a commit to BABA983/vscode that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants