Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deconstruct signalOptions config object, migrate settings #214163

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Jun 3, 2024

fix #213618

We added accessibility.signalOptions last iteration for easier discovery/grouping of these settings because they can otherwise get lost amongst the many accessibility.signals properties.

However, this had side effects:

  • the delays property couldn't be easily adjusted in the settings UI due to the multiple nested objects. discussed this with @rzhao271 and it's a limitation of the settings UI.
  • we want to track telemetry to determine if the experimental.delays are justified, but one cannot track data of a setting's property.
  • searching in the settings UI doesn't factor in setting properties

This destructures that object and migrates the settings.

cc @hediet

@meganrogge meganrogge self-assigned this Jun 3, 2024
@meganrogge meganrogge added this to the June 2024 milestone Jun 3, 2024
@meganrogge meganrogge enabled auto-merge (squash) June 3, 2024 18:04
@meganrogge meganrogge merged commit 21033da into main Jun 3, 2024
6 checks passed
@meganrogge meganrogge deleted the merogge/deconstruct-settings branch June 3, 2024 18:22
@hediet
Copy link
Member

hediet commented Jun 4, 2024

Thank you!

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

accessibility.signalOptions.delays not user friendly
4 participants