PromptInputModel: Update model when prompt changes without cursor movement #210706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
changed the title
joaomoreno
approved these changes
Apr 19, 2024
sergioengineer
pushed a commit
to sergioengineer/VimSCode
that referenced
this pull request
Apr 23, 2024
…or_still PromptInputModel: Update model when prompt changes without cursor movement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #210740
Summary:
onWriteParsedAPI for@xterm/headlessPromptInputModel._synconxterm.onWriteParsedcursorIndexto-1after a command has executed and align assertions in testsPromptInputModel._syncwith a delay of0instead ofdebounce(50), this allows us to not force a sync in the tests and instead justawait timeout(0). This is required to get the new test to fail before the fix