Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to electron 29 #209818

Merged
merged 24 commits into from
May 10, 2024
Merged

chore: update to electron 29 #209818

merged 24 commits into from
May 10, 2024

Conversation

deepak1556
Copy link
Collaborator

@deepak1556 deepak1556 commented Apr 8, 2024 •
edited
Loading

Fixes #210467

@deepak1556 deepak1556 added this to the April 2024 milestone Apr 8, 2024
@deepak1556 deepak1556 self-assigned this Apr 8, 2024
@deepak1556 deepak1556 force-pushed the electron-29.x.y branch 2 times, most recently from ec41e43 to aab3d14 Compare April 10, 2024 00:07
@deepak1556
Copy link
Collaborator Author

Depends on electron/electron#41830

@deepak1556 deepak1556 force-pushed the electron-29.x.y branch 5 times, most recently from d490508 to 0d30cf1 Compare April 16, 2024 12:44
@ChaseKnowlden ChaseKnowlden mentioned this pull request Apr 19, 2024
Closed
@deepak1556 deepak1556 modified the milestones: April 2024, May 2024 Apr 22, 2024
@deepak1556 deepak1556 force-pushed the electron-29.x.y branch 3 times, most recently from dd35000 to 2d106a1 Compare April 30, 2024 07:23
This was referenced May 3, 2024
Merged
Merged
@deepak1556 deepak1556 force-pushed the electron-29.x.y branch 5 times, most recently from c759471 to 57f061e Compare May 8, 2024 08:20
@deepak1556
chore: update [email protected]
0159cd6
@deepak1556
chore: update typings to 20.x
9064ef5
@deepak1556
chore: bump [email protected]
d56f671
@deepak1556
ci: fix crash in compiling extensions-ci
1b5fa1e
@deepak1556
chore: disable .d.ts check for build/
cab7839 
$ ../node_modules/.bin/tsc -p tsconfig.build.json
node_modules/@types/chokidar/index.d.ts:21:14 - error TS2420: Class 'import("/Users/demohan/github/vscode/build/node_modules/@types/chokidar/index").FSWatcher' incorrectly implements interface 'import("fs").FSWatcher'.
  Type 'FSWatcher' is missing the following properties from type 'FSWatcher': ref, unref

21 export class FSWatcher extends EventEmitter implements fs.FSWatcher {
                ~~~~~~~~~

node_modules/chokidar/types/index.d.ts:8:14 - error TS2420: Class 'import("/Users/demohan/github/vscode/build/node_modules/chokidar/types/index").FSWatcher' incorrectly implements interface 'import("fs").FSWatcher'.
  Type 'FSWatcher' is missing the following properties from type 'FSWatcher': ref, unref

8 export class FSWatcher extends EventEmitter implements fs.FSWatcher {
               ~~~~~~~~~

Found 2 errors in 2 files.

Errors  Files
     1  node_modules/@types/chokidar/index.d.ts:21
     1  node_modules/chokidar/types/index.d.ts:8

Refs paulmillr/chokidar@a0f9e09
@deepak1556
chore: update core types
efc02f9
@deepak1556 deepak1556 requested a review from bpasero May 10, 2024 12:39
@deepak1556 deepak1556 marked this pull request as ready for review May 10, 2024 12:39
bpasero
bpasero previously approved these changes May 10, 2024
View reviewed changes
@deepak1556 deepak1556 merged commit 5216c04 into main May 10, 2024
39 checks passed
@deepak1556 deepak1556 deleted the electron-29.x.y branch May 10, 2024 16:20