Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove notebook view from focus order & accessibility tree when hidden #209059

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Remove notebook view from focus order & accessibility tree when hidden #209059

merged 2 commits into from
Mar 29, 2024

Conversation

kycutler
Copy link
Contributor

@rebornix rebornix assigned amunger and meganrogge and unassigned rebornix Mar 28, 2024
@meganrogge meganrogge requested a review from amunger March 28, 2024 20:24
@amunger
Copy link
Contributor

amunger commented Mar 28, 2024

Tried this out - it does not fix the issue

@kycutler
Copy link
Contributor Author

My bad -- accidentally set the property on the wrong element. Should be working now, thanks!

@VSCodeTriageBot VSCodeTriageBot added this to the March 2024 milestone Mar 29, 2024
@amunger amunger enabled auto-merge (squash) March 29, 2024 15:55
@amunger amunger merged commit 9d98da3 into microsoft:main Mar 29, 2024
6 checks passed
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

@amunger amunger amunger approved these changes

Assignees

@amunger amunger

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
March 2024
Development

Successfully merging this pull request may close these issues.

Can tab through notebook when it's in the background
6 participants
@kycutler @amunger @bpasero @rebornix @meganrogge @VSCodeTriageBot