fix: render chat welcome if session init fails #195933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeschli
approved these changes
Oct 18, 2023
roblourens
reviewed
Oct 19, 2023
| @@ -121,6 +123,16 @@ export class ChatViewPane extends ViewPane implements IChatViewPane { | |||
| sessionId = this.viewState.sessionId; | |||
| } | |||
|
|
|||
| // Render the welcome view if this session gets disposed at any point, | |||
| // including if the provider registration fails | |||
| const disposeListener = sessionId ? this._register(this.chatService.onDidDisposeSession((e) => { | |||
There was a problem hiding this comment.
This flow is a little confusing, what case is this covering? And this will fire when the model is cleared normally too. Does this.didProviderRegistrationFail need to be reset somewhere?
There was a problem hiding this comment.
This is meant to cover the case where we have view state to restore but couldn't find a provider for it (i.e. user had a chat conversation and then signed out)--we should show a welcome view in this case because otherwise the chat window would be in an unusable state. Thoughts on instead having the chat service explicitly signal this case by throwing an UnknownProviderError that we can catch here in the view pane?
Alex0007
pushed a commit
to Alex0007/vscode
that referenced
this pull request
Oct 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to 23234ef, if we had some initial persisted session data we will temporarily show that, but if initializing a session from that fails, e.g. because the provider wasn't found, we will now render the welcome view
cc @roblourens