Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #194202 #194305

Merged
merged 2 commits into from
Sep 28, 2023
Merged

fix #194202 #194305

merged 2 commits into from
Sep 28, 2023

Conversation

benibenj
Copy link
Contributor

#194202

Change positio from static to relative as the tab border is set with absolut positioning. Makes sure to overwrite style.left set on the HTML element itself

@benibenj benibenj self-assigned this Sep 27, 2023
@benibenj benibenj enabled auto-merge (squash) September 27, 2023 14:18
@VSCodeTriageBot VSCodeTriageBot added this to the September 2023 milestone Sep 27, 2023
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finding, I suggest to use unset and also include z-index.

@benibenj benibenj merged commit b090720 into main Sep 28, 2023
6 checks passed
@benibenj benibenj deleted the benibenj/heightlightModifiesTabBug branch September 28, 2023 07:26
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants