Check for treatment and guard against malformed JSON in featured extension experiment #178180
Conversation
| this.title = extensionListTitle ?? localize('gettingStarted.featuredTitle', 'Featured'); | ||
|
|
||
| if (this.treatment) { | ||
| if (this.treatment?.extensions && Array.isArray(this.treatment.extensions)) { |
There was a problem hiding this comment.
I think this might regress the fix that you introduced for #177945 because this.treatment.extensions isn't guaranteed to be an array (depending on what comes back from the experimentation service)?
There was a problem hiding this comment.
Array.isArray takes care of the check for extensions being an array before the for loop iterates on it. Tested it with sample strings.
There was a problem hiding this comment.
Just for my understanding, do you know what the exp service was returning when #177945 repros? (i.e. was it just an empty response which could be safely skipped, or was it returning extension info in a different shape like an object rather than an array)? I'm mainly wondering if the Array.isArray check would cause us to not feature extensions if the exp service happens to return objects (which Object.values would still be able to extract).
There was a problem hiding this comment.
It was returning an empty response '{}' for a very small control group (2%). I don't believe my first fix handled it in its entirety.
This can be safely skipped and it will not cause us to not feature extensions.
Fixes: #177945
See comment here: #178164 (review)