Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve command URL eventually #178061

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Resolve command URL eventually #178061

merged 1 commit into from
Mar 23, 2023

Conversation

joyceerhl
Copy link
Contributor

Fixes #177942

@joyceerhl joyceerhl enabled auto-merge (squash) March 22, 2023 19:03
@joyceerhl joyceerhl self-assigned this Mar 22, 2023
@joyceerhl joyceerhl requested a review from alexr00 March 22, 2023 19:03
@vscodenpa vscodenpa added this to the March 2023 milestone Mar 22, 2023
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this change as it means that the second time that the user clicks on the help and feedback item the codespaces entry will show, but it does not cause the quick pick to populate with more entries while it's still open as described in #177942 (comment)

@alexr00 alexr00 disabled auto-merge March 23, 2023 09:34
@joyceerhl joyceerhl merged commit 46d7e02 into main Mar 23, 2023
@joyceerhl joyceerhl deleted the dev/joyceerhl/happy-hawk branch March 23, 2023 16:11
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote explorer help and feedback buttons are busted after installing code spaces extension
3 participants