Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terminal tab hover action for env changes #177730

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Add terminal tab hover action for env changes #177730

merged 2 commits into from
Mar 20, 2023

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Mar 20, 2023

Fixes #177128

@lramos15 is the editor service usage correct?

image

image

lramos15
lramos15 previously approved these changes Mar 20, 2023
Copy link
Member

@lramos15 lramos15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editor changes look good 👍

Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩 so cool

const editorService = accessor.get(IEditorService);
await editorService.openEditor({
resource: URI.from({
scheme: Schemas.untitled
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the readonly inMemory scheme make more sense in this use case?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like this is what I want, but I tried and get this. Am I doing something wrong?

image

I wanted to avoid creating a file service provider for a scheme

@Tyriar Tyriar merged commit eba1361 into main Mar 20, 2023
@Tyriar Tyriar deleted the tyriar/177128 branch March 20, 2023 23:13
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add terminal tab hover action to show environment variable contributions
4 participants