add linter for css variable names #176769
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a linter that checks that all used variable names that appear in css files are known.
The linter is part of hygiene or can be run with
yarn stylelint
All known variables are in a file
vscode-known-variables.json
. To validate thatvscode-known-variables.json
is up-to-date, run./scripts/test-documentation
(that test also verifies that all color variables are documented)This linter just uses regexp on line content, it doesn't understand CSS (in particular comment tokens). In a a follow up PR I have a solution that's based on stylelint.
The PR also fixes some wrongly named variables.