chore: update to Electron 22 #166430
Merged
chore: update to Electron 22 #166430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c2ee655
to
073e3f8
Compare
073e3f8
to
64b4097
Compare
|
This is blocked on Electron missing https://source.chromium.org/chromium/chromium/src/+/main:buildtools/third_party/libc++/trunk/include/__memory_resource/; headers from the libcxx bundle shipped. |
5efaccc
to
9718242
Compare
9718242
to
dd2e68c
Compare
dd2e68c
to
cf89d6c
Compare
5d948e6
to
fe17055
Compare
3137bee
to
085fa33
Compare
7b2de25
to
c653027
Compare
9aa94f9
to
f70db26
Compare
e4a1101
to
3b2421e
Compare
deepak1556
commented
Feb 28, 2023
| @@ -91,7 +91,7 @@ function darwinBundleDocumentTypes(types: { [name: string]: string | string[] }, | |||
| } | |||
|
|
|||
| export const config = { | |||
| version: product.electronRepository ? '19.1.11' : util.getElectronVersion(), | |||
| version: product.electronRepository ? '22.10.0' : util.getElectronVersion(), | |||
There was a problem hiding this comment.
I will update this to an official version once the PGO related builds are available in a follow-up PR. For now, lets merge with the custom version to get insiders coverage.
|
I will update distro once this is merged. |
bpasero
reviewed
Feb 28, 2023
bpasero
reviewed
Feb 28, 2023
bpasero
approved these changes
Feb 28, 2023
aeschli
approved these changes
Feb 28, 2023
deepak1556
added a commit
that referenced
this pull request
Mar 2, 2023
This reverts commit 6e85d2b.
deepak1556
added a commit
that referenced
this pull request
Mar 2, 2023
* Revert "Update to min supported version of node (#175723)" This reverts commit f749e6b. * Revert "chore: update min node version for development (#175663)" This reverts commit f2a822f. * Revert "electron 22 sandbox - enable for OSS (#175659)" This reverts commit 2551af2. * Revert "chore: update to Electron 22 (#166430)" This reverts commit 6e85d2b.
|
Has this PR been reverted? |
|
@samuelstroschein yes in favor of #175843, we will post more context in the following week. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #166265
Fixes #156723
Fixes #163736
Fixes #157184
Fixes #154666
Fixes #144791
Refs https://github.com/microsoft/vscode-encrypt/issues/33