Better handle markup rendering errors in notebooks #161153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show an error to users if rendering of markup items fail. Previously when a renderer fails to load or render, we would not show any user facing errors (and would sometimes prevent the entire notebook from loading)
mjbvz
commented
Sep 16, 2022
| @@ -716,8 +716,18 @@ async function webviewPreloads(ctx: PreloadContext) { | |||
| }; | |||
| } | |||
|
|
|||
| function showPreloadErrors(outputNode: HTMLElement, ...errors: readonly Error[]) { | |||
| outputNode.innerText = `Error loading preloads:`; | |||
| async function renderOutputItem(rendererApi: rendererApi.RendererApi, rendererId: string, item: rendererApi.OutputItem, element: HTMLElement, signal: AbortSignal) { | |||
There was a problem hiding this comment.
Eventually I'm planning to have both markup and output elements go through the same rendering pipeline
For legacy reasons, we currently have two pipelines that do different things. This PR gets them to be a little more similar
mjbvz
changed the title
alexdima
approved these changes
Sep 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show an error to users if rendering of markup items fail. Previously when a renderer fails to load or render, we would not show any user facing errors (and would sometimes prevent the entire notebook from loading)