RPM packaging: Use standard macros #153247
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, which builds on #142907 (and stems from the discussion in #142907 (comment)), updates the RPM spec file to use standard RPM macros where appropriate in the package definition.
@@NAME@@
is replaced into the specfile definition ofName:
, its value can be referenced using the%{name}
macro, requiring less substitution on the template specfile.%{_bindir}
and%(_datadir}
are preferred, when specifying paths for installed files (either in the%{builddir}
tree, during%install
, or in the%files
list).Also:
%install
section are now sorted to match the other references to those paths throughout the file%install
up into coarse sections, each labeled with a preceding comment