Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: change yarn web to run with our server instead of playground #139725

Merged
merged 19 commits into from
Jan 20, 2022

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Dec 24, 2021

This removes your playground yarn web runner in favour of opening web UI via our server

@bpasero bpasero added this to the January 2022 milestone Dec 24, 2021
@bpasero bpasero requested a review from aeschli December 24, 2021 11:59
@bpasero bpasero self-assigned this Dec 24, 2021
@bpasero bpasero changed the title Ben/yarn web Web: change yarn web to run with our server instead of playground Dec 24, 2021
@bpasero
Copy link
Member Author

bpasero commented Dec 27, 2021

One argument from @alexdima in standup today was that this change means we loose the ability to test our bits in a "serverless" environment.

Some ideas and questions:

  • make our server also support a "serverless" mode so that we avoid having 2 different servers
  • do we need 2 yarn web commands for "serverless" and "serverful"

@aeschli
Copy link
Contributor

aeschli commented Jan 18, 2022

@bpasero I pushed my changes to use @vscode/test-web to run the serverless web from sources.

I clean up the commands and names:
There are now

  • ./scripts/code-server for running the code-server and opening a browser on it
  • /scripts/code-web for running VSCode in the Web (serverless)

I removed yarn web in favor of the other scripts

The Web UI of the code-server-web still doesn't come up (page stays white). I'll have a look.

@bpasero
Copy link
Member Author

bpasero commented Jan 19, 2022

@aeschli I like it!

Running yarn web on macOS I get this now:

~/Development/Microsoft/monaco> yarn web
yarn run v1.22.17
$ echo \'yarn web\' is replaced by `./scripts/code-server-web` or `./scripts/code-web`
/bin/sh: ./scripts/code-server-web: No such file or directory
/bin/sh: ./scripts/code-web: No such file or directory
'yarn web' is replaced by or
✨  Done in 0.04s.
~/Development/Microsoft/monaco>

@bpasero
Copy link
Member Author

bpasero commented Jan 19, 2022

Also it seems to open a Chrome instance that is not my installed Chrome, are you shipping Playwright?

@bpasero bpasero assigned aeschli and bpasero and unassigned bpasero Jan 19, 2022
@bpasero
Copy link
Member Author

bpasero commented Jan 19, 2022

I pushed a fix for yarn web not working.

@aeschli
Copy link
Contributor

aeschli commented Jan 19, 2022

Yes, the @vscode/test-web extension uses Playwright.
Would you prefer not to open a Playwright browser but your system one?

@bpasero
Copy link
Member Author

bpasero commented Jan 19, 2022

@aeschli yes!

@aeschli
Copy link
Contributor

aeschli commented Jan 19, 2022

For code-web we now use the system browser. You can still pass --browserType with chromium, firefox and webkit to test on these browsers

@bpasero
Copy link
Member Author

bpasero commented Jan 19, 2022

👏

@bpasero bpasero merged commit 13461f8 into main Jan 20, 2022
@bpasero bpasero deleted the ben/yarn-web branch January 20, 2022 12:48
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants