-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web: change yarn web
to run with our server instead of playground
#139725
Conversation
yarn web
to run with our server instead of playground
One argument from @alexdima in standup today was that this change means we loose the ability to test our bits in a "serverless" environment. Some ideas and questions:
|
@bpasero I pushed my changes to use I clean up the commands and names:
I removed The Web UI of the code-server-web still doesn't come up (page stays white). I'll have a look. |
@aeschli I like it! Running
|
Also it seems to open a Chrome instance that is not my installed Chrome, are you shipping Playwright? |
I pushed a fix for |
Yes, the @vscode/test-web extension uses Playwright. |
@aeschli yes! |
For |
👏 |
This removes your playground
yarn web
runner in favour of opening web UI via our server