Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for markdown notebook renderers #115191

Merged
merged 23 commits into from
Feb 11, 2021

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Jan 27, 2021

Fixes #106701

This PR adds a new extension point that allows extensions to either replace or augment the rendering of markdown in notebooks. To do this, we've moved the rendered markdown from our main editor dom into the back layer webview of the notebook.

Todos

  • Make a more thorough test of accessibility with these changes
  • When pre-rendering the notebook cells on first load, look at cell position cache instead of just getting first five cells
  • Move the math contribution into a new extension
  • Make sure that only core extensions can fully replace the markdown renderer for now
  • Figure out markdown extensions should be contributed. Right now they come in the same way replacement markdown renderers do
  • Improve drag + drop of cells. Currently there are noticeable delays

@mjbvz mjbvz added this to the February 2021 milestone Jan 27, 2021
@mjbvz mjbvz force-pushed the dev/mjbvz/notebook-markdown-renderers branch from 359d41b to 2463415 Compare January 27, 2021 06:31
@mjbvz mjbvz force-pushed the dev/mjbvz/notebook-markdown-renderers branch from 2463415 to 53a61c1 Compare February 10, 2021 01:15
@mjbvz mjbvz marked this pull request as ready for review February 11, 2021 00:41
@mjbvz mjbvz merged commit 35f8557 into master Feb 11, 2021
@mjbvz mjbvz deleted the dev/mjbvz/notebook-markdown-renderers branch February 11, 2021 00:41
@mjbvz
Copy link
Collaborator Author

mjbvz commented Feb 11, 2021

Merging for testing but will continue following up on remaining TODOs

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore customizing the markdown renderer for notebooks
2 participants