Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bypass for CVE-2020-16881 #107952

Merged
merged 2 commits into from
Oct 2, 2020
Merged

Fix a bypass for CVE-2020-16881 #107952

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8ceafb
Fix a bypass for CVE-2020-16881
justinsteven Oct 2, 2020
7c91cee
Merge branch 'master' into bugfix/fix_CVE-2020-16881_bypass
aeschli Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions extensions/npm/src/features/packageJSONContribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,8 +282,8 @@ export class PackageJSONContribution implements IJSONContribution {

private npmView(pack: string): Promise<ViewPackageInfo | undefined> {
return new Promise((resolve, _reject) => {
const command = 'npm view --json ' + pack + ' description dist-tags.latest homepage version';
cp.exec(command, (error, stdout) => {
const args = ['view', '--json', pack, 'description', 'dist-tags.latest', 'homepage', 'version'];
cp.execFile('npm', args, (error, stdout) => {
if (!error) {
try {
const content = JSON.parse(stdout);
Expand Down