Include terminal name in terminal textarea title

[Tyriar]

Currently focusing the terminal reads something like "Terminal 1", "Terminal 2". It should read "Terminal 1, bash", "Terminal 2, (custom title)", etc.

Context: #95573 (comment)

[chrisnorman7]

Or simply the title you set... Maybe the title, then "Terminal 1" in brackets?

[chrisnorman7]

Or maybe go absolutely wild, and have it as a configurable string. Something like "$n (Terminal $i)", where $n is the name you set, and $i is the index.

[tabaddor]

I can look into fixing this issue if it is still open, although I do see it has been added to the backlog.

[Tyriar]

@tabaddor please do 🙂, the backlog for us essentially means we want to do this eventually.

[tabaddor]

On it. @chrisnorman7 Quick clarification, but what was meant by "custom title" in the issue description above?

I guess more specifically, with Terminal X, (custom), is the (custom) the user's choice? How will that terminal name be determined? (looking at the context linked above, it seems it should be what was set for the rename terminal action)

Additionally, before I delve into the source code, can you briefly clarify "focusing" on the textarea @Tyriar? Can't seem to recreate that on the development version or released version.

[Tyriar]

@tabaddor by custom I mean when you rename a terminal via this command:

Additionally, before I delve into the source code, can you briefly clarify "focusing" on the textarea @Tyriar? Can't seem to recreate that on the development version or released version.

The label is set here:

vscode/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts

Line 487 in 162abc7

xterm.textarea.setAttribute('aria-label', nls.localize('terminalTextBoxAriaLabel', "Terminal {0}", this._id));

You'll need a screen reader to verify whether it's read correctly but I expect the change to be on that line.

[chrisnorman7]

Not sure what the image says, but when you rename the terminal with the "Terminal: Rename" command. Thanks so much for dealing with it. Take care, Chris Norman

…

On Mon, 8 Jun 2020 at 18:36, Daniel Imms ***@***.***> wrote: @tabaddor <https://github.com/tabaddor> by custom I mean when you rename a terminal via this command: [image: image] <https://user-images.githubusercontent.com/2193314/84062167-d9e1ab80-a973-11ea-9c94-1bc0b751d552.png> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#99072 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBUZ2IONQFIMK63RM2XJ5TRVUOR3ANCNFSM4NQVEKNQ> .

[tabaddor]

I anticipate changing this line:

vscode/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts

Line 487 in 162abc7

xterm.textarea.setAttribute('aria-label', nls.localize('terminalTextBoxAriaLabel', "Terminal {0}", this._id));

to this:

xterm.textarea.setAttribute('aria-label', nls.localize('terminalTextBoxAriaLabel', "Terminal {this._id}, {this._title}"));

Though prior to setting this attribute I anticipate I will need to add a check to see if the title was set or not, along with ensuring this attribute is updated on title changes (renamed instances). Although the latter should already be accounted for.

[Tyriar]

To get localization to work it will need to be "Terminal {0}, {1}", this._id, this._title), and yes good thinking we should have an if in there are 2 separate nls.localize calls, one with and one without the title.

[tabaddor]

Will submit a PR shortly.

[roblourens]

Where should I see this? When I focus the terminal, voiceover reads "Terminal 1, edit text, complentary"

[alexr00]

I'm also not getting what I'd expect from this issue.

What's read:
Terminal 2 edit
blank

Red dot where I clicked:

What I'd expect that to read: "Terminal 2 powershell"

[weisun022]

I'm going to take a shot at this for Grace Hopper's Open Source Day!

[isidorn]

Here's a code poitner (not specific enough though)

vscode/src/vs/workbench/contrib/terminal/browser/terminalView.ts

Line 34 in b8e87aa

export class TerminalViewPane extends ViewPane {

[plainerman]

I see that this issue hasn't been fully resolved as of now. I would like to try to fix it if it is still available to work on.

As I am completely new to this project, I would appreciate some code pointers. With the pointers above I have already found out where the string "said by the narrator" is set. But could someone point me to the entry point for Terminal:Rename?

Thank you, looking forward to making my first contribution.

[plainerman]

I found the entry point of Terminal:Rename and have resolved the issue.
A pull request has been created at #112317.

If anyone is searching for the entry point, see

vscode/src/vs/workbench/contrib/terminal/browser/terminalActions.ts

Line 952 in b2444f5

async run(accessor: ServicesAccessor) {

[isidorn]

Thanks a lot for creating a PR!