Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree Guide Indents not showing in latest Insiders (1.41) #86662

Closed
DeltaRazero opened this issue Dec 10, 2019 · 6 comments
Closed

Tree Guide Indents not showing in latest Insiders (1.41) #86662

DeltaRazero opened this issue Dec 10, 2019 · 6 comments
Assignees
Labels
candidate Issue identified as probable candidate for fixing in the next release confirmed Issue has been confirmed by VS Code Team member regression Something that used to work is now broken verified Verification succeeded
Milestone

Comments

@DeltaRazero
Copy link

Tree guide indents will not show up at all in the latest insider build, regardless of always enabled or show on hover.

Version: 1.41.0-insider
Commit: bef029a9d21904c0085c4e8ef1335d9c33a28fa4
Date: 2019-12-09T15:42:51.762Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 6.1.7601

Does this issue occur when all extensions are disabled?: Yes

@IllusionMH
Copy link
Contributor

Looks like elements are there, but have border-left: 1px solid transparent;

@gjsjohnmurray
Copy link
Contributor

/confirm this is a regression in 1.41.

@sbatten should this be tagged as a candidate for fixing before release?

@vscodebot vscodebot bot added the confirmed Issue has been confirmed by VS Code Team member label Dec 10, 2019
@sbatten sbatten added candidate Issue identified as probable candidate for fixing in the next release regression Something that used to work is now broken labels Dec 10, 2019
@isidorn
Copy link
Contributor

isidorn commented Dec 10, 2019

I am investigating when this broke exactly..
@DeltaRazero if you know that it worked with some previous insiders do tell me.

@isidorn isidorn self-assigned this Dec 10, 2019
@isidorn
Copy link
Contributor

isidorn commented Dec 10, 2019

@IllusionMH You are correct that the transparent color is the issue here, if I remove the transparent they get nicely rendered. However we always had that code. I believe this indent guides can be styled, and that styling got broke. Investigating more

This looks fishy here. Never do I get a style with an treeIndentGuidesStroke

fyi @misolori

@isidorn
Copy link
Contributor

isidorn commented Dec 10, 2019

The following commit broke it 75a778d
However we can not just revert the commit since that breaks tree selection. So that commit screwed up how the default styler is being set to the tree. Investingating..

@isidorn
Copy link
Contributor

isidorn commented Dec 10, 2019

Ok found a fix, creating a PR.

@sbatten sbatten added this to the November 2019 milestone Dec 10, 2019
@sbatten sbatten closed this as completed Dec 10, 2019
@eamodio eamodio added the verified Verification succeeded label Dec 10, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
candidate Issue identified as probable candidate for fixing in the next release confirmed Issue has been confirmed by VS Code Team member regression Something that used to work is now broken verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

7 participants