Our src/typings folder needs to go away

[bpasero]

Rather, we should move to a model where we reference the types from our package.json. Unfortunately this will mean quite a bit of work for all modules that currently either do not ship with types or do not have an entry in the DefinitelyTyped repository.

We can split this up by module owner, but someone needs to drive this ideally.

• electron.d.ts @deepak1556
• lib.es2018.promise.d.ts @jrieken
• semver-umd.d.ts @sandy081
• thenable.d.ts @jrieken
• vscode-windows-registry.d.ts @sbatten (MUST go through @types/xyz because optional dep)
• vsda.d.ts @weinand
• windows-mutex.d.ts @bpasero (MUST go through @types/xyz because optional dep)

[bpasero]

I removed the following:

• chokidar
• iconv-lite
• graceful-fs

[Tyriar]

I removed modifications to xterm.d.ts, will it work by pulling the types from the module now or does it need @types?

[mjbvz]

Opened the-ress/node-windows-foreground-love#4 for moving typings into the library itself. However since this library is optional and not installed on Mac/Linux builds, I'm not sure if this is the correct solution

[mjbvz]

Opened microsoft/node-spdlog#7 for spdlog

[joaomoreno]

[email protected] has been released with typings

[mjbvz]

@joaomoreno Can you please pick up the new spdlog version. I reverted my change with 768399b since it broken the remote checks

[joaomoreno]

@mjbvz Done!

[jrieken]

fyi - I have added trustworthy checkboxes and names as good as I could. also, to clarify: we cannot get rid of everything here (e.g IE11 specials) but we should aim at removing all d.ts-files for node_modules. If you/we own a node_module they should ship a d.ts-file and otherwise we need to adding to the typings registry

[bpasero]

I updated the list based on what we still have.

@weinand I think VSDA was signed off but I still see it.

@jrieken there are quite a bit of d.ts still around which I think are not there because of a node module dependency. I was not sure if the 2 in the list fall into that category, please check.

[jrieken]

Yeah, they are both needed. The Thenable is required to implement the API and the promise extension is for our finally-polyfill that we have.

[weinand]

@bpasero I've added an index.d.ts to vsda but I was not able to remove vsda from src/typings because vsda is an optional dependency. Therefore I've added the "(MUST go through @types/xyz because optional dep)".
If you know a better solution please let me know.

[bpasero]

@weinand right, it needs to go to DefnitleyTyped 👍

[weinand]

There is now a SignService without a dependency on vsda.

[bpasero]

Created the following PRs for the remaining types:

• Add types for vscode-windows-registry DefinitelyTyped/DefinitelyTyped#40962
• add types for windows-mutex DefinitelyTyped/DefinitelyTyped#40873