-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Our src/typings folder needs to go away #83421
Comments
I removed the following:
|
I removed modifications to xterm.d.ts, will it work by pulling the types from the module now or does it need |
Opened the-ress/node-windows-foreground-love#4 for moving typings into the library itself. However since this library is optional and not installed on Mac/Linux builds, I'm not sure if this is the correct solution |
Opened microsoft/node-spdlog#7 for spdlog |
|
Allows us to remove our typings as part of #83421
@joaomoreno Can you please pick up the new spdlog version. I reverted my change with 768399b since it broken the remote checks |
@mjbvz Done! |
fyi - I have added trustworthy checkboxes and names as good as I could. also, to clarify: we cannot get rid of everything here (e.g IE11 specials) but we should aim at removing all d.ts-files for node_modules. If you/we own a node_module they should ship a d.ts-file and otherwise we need to adding to the typings registry |
Yeah, they are both needed. The Thenable is required to implement the API and the promise extension is for our finally-polyfill that we have. |
@bpasero I've added an index.d.ts to vsda but I was not able to remove vsda from src/typings because vsda is an optional dependency. Therefore I've added the "(MUST go through @types/xyz because optional dep)". |
@weinand right, it needs to go to DefnitleyTyped 👍 |
There is now a SignService without a dependency on vsda. |
Created the following PRs for the remaining types: |
Rather, we should move to a model where we reference the types from our
package.json
. Unfortunately this will mean quite a bit of work for all modules that currently either do not ship with types or do not have an entry in theDefinitelyTyped
repository.We can split this up by module owner, but someone needs to drive this ideally.
The text was updated successfully, but these errors were encountered: