Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support non file workspace URIs #66907

Closed
sandy081 opened this issue Jan 22, 2019 · 5 comments
Closed

Support non file workspace URIs #66907

sandy081 opened this issue Jan 22, 2019 · 5 comments
Assignees
@sandy081
Labels
config VS Code configuration, set up issues feature-request Request for new features or functionality on-testplan
Milestone
February 2019

Comments

@sandy081
Copy link
Member

Support non file workspace URIs
@sandy081 sandy081 added the config VS Code configuration, set up issues label Jan 22, 2019
@sandy081 sandy081 self-assigned this Jan 22, 2019
@sandy081 sandy081 added the feature-request Request for new features or functionality label Jan 22, 2019
@sandy081 sandy081 added this to the December/January 2019 milestone Jan 22, 2019
sandy081 added a commit that referenced this issue Jan 22, 2019
@sandy081
#66907 Move cached configurations to user home directory
b29504c
sandy081 added a commit that referenced this issue Jan 22, 2019
@sandy081
#66907 Support non file workspaces
c5486fe 
- File workspaces: Use node services until file service is acquired
- Non file workspaces:  Use cached workspace until file service is acquired
sandy081 added a commit that referenced this issue Jan 23, 2019
@sandy081
#66907 💄
11f3201
@sandy081
Copy link
Member Author

@aeschli @bpasero Implemented the delayed loading of workspace folders strategy for non file workspaces. But this will restart extension host because the first folder has changed.

@bpasero I think we are restarting the extension host because the rootPath will change. Shall we not restart the extension host and just update the rootPath with first folder?

@bpasero
Copy link
Member

bpasero commented Jan 23, 2019

I think we are restarting the extension host because the rootPath will change

Yes

Shall we not restart the extension host and just update the rootPath with first folder?

We cannot, this will break extensions. The contract is that the rootPath is set like a constant on startup.

@sandy081
Copy link
Member Author

Isn't the root path resembles Single Folder case? How does it break extensions in a Multi root workspace that goes from 0 to 1 (or >1) folders?

@bpasero
Copy link
Member

bpasero commented Jan 24, 2019 •
edited
Loading

It does not, we always restart the extension host currently whenever the first folder changes.

@sandy081
Copy link
Member Author

Fixed extension host restarting issue by delaying listening to workspace change until the workspace is complete.

Second issue to fix is delay starting extension host until workspace is complete so that the rootPath is set correctly.

sandy081 added a commit that referenced this issue Jan 28, 2019
@sandy081
#66907 Delay listening to workspace change events until it is complete
1f28c5f
@sandy081 sandy081 mentioned this issue Jan 28, 2019
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
config VS Code configuration, set up issues feature-request Request for new features or functionality on-testplan
Projects
None yet
Milestone
February 2019
Development

No branches or pull requests
2 participants
@bpasero @sandy081