Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emmet extension should use shared tsconfig #59803

Closed
mjbvz opened this issue Oct 2, 2018 · 0 comments
Closed

emmet extension should use shared tsconfig #59803

mjbvz opened this issue Oct 2, 2018 · 0 comments
Assignees
Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc.
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Oct 2, 2018

Replace the emmet extension 's custom tsconfig with one that extends our new shared tsconfig:

{
	"extends": "../shared.tsconfig.json",
	"compilerOptions": {
		"outDir": "./out"
	},
	"exclude": [
		"node_modules",
		".vscode-test"
	],
	"include": [
		"src/**/*"
	]
}

This shared tsconfig will ensure that all of our extensions target the same environment. It will also help enforce consistent code quality standards across extensions.

As part of adopting the shared tsconfig, code changes are needed in the emmet extension to make sure it can build in strict mode with noUnusedLocals and noUnusedParameters enabled. Please let me know if you have any questions about fixing these errors.

@mjbvz mjbvz added the engineering VS Code - Build / issue tracking / etc. label Oct 2, 2018
@ramya-rao-a ramya-rao-a added the debt Code quality issues label Oct 3, 2018
@ramya-rao-a ramya-rao-a added this to the October 2018 milestone Oct 3, 2018
ramya-rao-a added a commit that referenced this issue Oct 3, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Development

No branches or pull requests

2 participants