-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
files.trimFinalNewlines unnecessarily adds extra event to undo history #46075
Milestone
Comments
AiryShift
added a commit
to AiryShift/vscode
that referenced
this issue
Mar 21, 2018
This should reproduce the bug as described in microsoft#46075 but doesn't
alexdima
added a commit
to AiryShift/vscode
that referenced
this issue
Mar 28, 2018
alexdima
added
bug
Issue identified by VS Code Team member as probable bug
and removed
editor
editor-core
Editor basic functionality
labels
Mar 28, 2018
alexdima
added a commit
that referenced
this issue
Mar 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This was also discussed in #39750 and apparently fixed in #39845, but I'm still experiencing this.
Steps to reproduce:
files.trimFinalNewlines
totrue
in settings.Ensure that there's an empty newline at the end. Save it. Then hit Undo. Nothing will happen. Hit Undo again, then it will work as expected.
You can even hit Save multiple times, and each time will add one extra step to the Undo list. So hit Save 10 times, then you can hit Undo 10 times and nothing will happen.
@AiryShift Could you take a look at this if possible?
The text was updated successfully, but these errors were encountered: