Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify the user when debug is blocked on prelaunch tasks #218267

Closed
bpasero opened this issue Jun 26, 2024 · 8 comments · Fixed by #224329
Closed

Notify the user when debug is blocked on prelaunch tasks #218267

bpasero opened this issue Jun 26, 2024 · 8 comments · Fixed by #224329
Assignees
@roblourens @connor4312
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues papercut 🩸 A particularly annoying issue impacting someone on the team
Milestone
August 2024

Comments

@bpasero
Copy link
Member

bpasero commented Jun 26, 2024 •
edited
Loading

Clone https://github.com/microsoft/vscode-dev and npm install. Hit F5, it never starts:

image

I am on macOS.
@bpasero bpasero added the papercut 🩸 A particularly annoying issue impacting someone on the team label Jun 26, 2024
@connor4312
Copy link
Member

This is probably because a prelaunch task is still running / your problem matchers haven't matched anything. Please make sure you have the right problem matchers installed, otherwise I suggest opening issues for them if they don't match correctly.

@connor4312 connor4312 added the info-needed Issue requires more information from poster label Jun 26, 2024
@bpasero
Copy link
Member Author

bpasero commented Jun 27, 2024

Would be great if debug could give me a hint.

@bpasero bpasero closed this as completed Jun 27, 2024
@connor4312
Copy link
Member

Will keep open to track it, it's not a rare problem

@connor4312 connor4312 reopened this Jun 27, 2024
@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues and removed info-needed Issue requires more information from poster labels Jun 27, 2024
@connor4312 connor4312 changed the title F5 does not work with vscode.dev Notify the user when debug is blocked on prelaunch tasks Jun 27, 2024
@connor4312 connor4312 added this to the July 2024 milestone Jun 27, 2024
@connor4312 connor4312 mentioned this issue Jul 7, 2024
Closed
@connor4312 connor4312 modified the milestones: July 2024, August 2024 Jul 24, 2024
@connor4312
Copy link
Member

We should also keep the terminal open if the task fails, currently it closes immediately which can be confusing

@connor4312 connor4312 assigned roblourens and unassigned connor4312 Jul 25, 2024
@joyceerhl
Copy link
Contributor

Would also be nice if we could cancel the pending launch attempt, e.g. by showing the debug toolbar immediately and disabling all buttons except the stop button. Right now when I get into this state I end up just reloading the whole window and incurring the pain of all extensions reactivating, which takes several seconds on my machine (git, TS etc)

@connor4312 connor4312 assigned connor4312 and unassigned joaomoreno Jul 25, 2024
@connor4312 connor4312 mentioned this issue Jul 30, 2024
Closed
connor4312 added a commit that referenced this issue Jul 30, 2024
@connor4312
debug: improve behavior for slow-running prelaunch tasks
0fe1808 
Shows this notification if a prelaunch task has been running for more
than 10 seconds:

![](https://memes.peet.io/img/24-07-be15cd9d-c9cd-40dc-8937-9d62466e5c96.png)

Also does a little cleanup of some probably-leaking disposables in the task runner.

Fixes #218267
@connor4312 connor4312 mentioned this issue Jul 30, 2024
Merged
@connor4312
Copy link
Member

After 10 seconds we'll show

image

@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jul 30, 2024
connor4312 added a commit that referenced this issue Jul 31, 2024
@connor4312
editor: fix glyph margin links not working (#224352)
f7deb0a 
* debug: improve behavior for slow-running prelaunch tasks

Shows this notification if a prelaunch task has been running for more
than 10 seconds:

![](https://memes.peet.io/img/24-07-be15cd9d-c9cd-40dc-8937-9d62466e5c96.png)

Also does a little cleanup of some probably-leaking disposables in the task runner.

Fixes #218267

* hygenie

* editor: fix glyph margin links not working

The constructor was missing decorations, so _openingService was always undefined and links did not open.

Fixes #214786

cc @aiday-mar
@vs-code-engineering vs-code-engineering bot removed the unreleased Patch has not yet been released in VS Code Insiders label Jul 31, 2024
@vs-code-engineering VS Code Engineering
Copy link

Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the insiders-released label directly, or comment \closedWith someShaThatWillbeReleasedWhenThisIsRelesed.

@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jul 31, 2024
connor4312 added a commit that referenced this issue Jul 31, 2024
@connor4312
dom: make SafeTriangle smaller, add tests (#224401)
6f2764a 
* debug: improve behavior for slow-running prelaunch tasks

Shows this notification if a prelaunch task has been running for more
than 10 seconds:

![](https://memes.peet.io/img/24-07-be15cd9d-c9cd-40dc-8937-9d62466e5c96.png)

Also does a little cleanup of some probably-leaking disposables in the task runner.

Fixes #218267

* hygenie

* dom: make SafeTriangle smaller, add tests
@vs-code-engineering vs-code-engineering bot removed the unreleased Patch has not yet been released in VS Code Insiders label Jul 31, 2024
@vs-code-engineering VS Code Engineering
Copy link 

		Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting `\closedWith someCommitSha`, or directly add the `insiders-released` label if you know this has already been releaased

@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Jul 31, 2024
connor4312 added a commit that referenced this issue Aug 1, 2024
@connor4312
debug/variables: autofill input from an LRU (#224531)
930be4a 
* debug: improve behavior for slow-running prelaunch tasks

Shows this notification if a prelaunch task has been running for more
than 10 seconds:

![](https://memes.peet.io/img/24-07-be15cd9d-c9cd-40dc-8937-9d62466e5c96.png)

Also does a little cleanup of some probably-leaking disposables in the task runner.

Fixes #218267

* hygenie

* debug/variables: autofill input from an LRU

This keeps a small LRU in the config resolver and storage service to provide default values, when not otherwise specified, for inputs in e.g. debugging.

I added this after I was annoyed by having to keep autofilling the same ephemeral value in some debug configs earlier.
@vs-code-engineering vs-code-engineering bot removed the unreleased Patch has not yet been released in VS Code Insiders label Aug 2, 2024
BABA983 pushed a commit to BABA983/vscode that referenced this issue Aug 2, 2024
@connor4312 @BABA983
debug/variables: autofill input from an LRU (microsoft#224531)
edda1e4 
* debug: improve behavior for slow-running prelaunch tasks

Shows this notification if a prelaunch task has been running for more
than 10 seconds:

![](https://memes.peet.io/img/24-07-be15cd9d-c9cd-40dc-8937-9d62466e5c96.png)

Also does a little cleanup of some probably-leaking disposables in the task runner.

Fixes microsoft#218267

* hygenie

* debug/variables: autofill input from an LRU

This keeps a small LRU in the config resolver and storage service to provide default values, when not otherwise specified, for inputs in e.g. debugging.

I added this after I was annoyed by having to keep autofilling the same ephemeral value in some debug configs earlier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roblourens roblourens

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues papercut 🩸 A particularly annoying issue impacting someone on the team
Projects
None yet
Milestone
August 2024
Development

Successfully merging a pull request may close this issue.

debug: improve behavior for slow-running prelaunch tasks microsoft/vscode
6 participants
@joaomoreno @roblourens @bpasero @connor4312 @joyceerhl @VSCodeTriageBot