Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong API proposal error/warning #218058

Closed
jrieken opened this issue Jun 25, 2024 · 5 comments · Fixed by #218182
Closed

Wrong API proposal error/warning #218058

jrieken opened this issue Jun 25, 2024 · 5 comments · Fixed by #218182
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded
Milestone
June 2024

Comments

@jrieken
Copy link
Member

jrieken commented Jun 25, 2024

  • latest insiders
  • latest chat prerelease
  • reload window
  • 🐛 the following warning appears on the console ⬇️
ERR Extension 'github.copilot-chat' wants API proposal 'lmTools@2' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check 'vscode.d.ts') or was abandoned.
@gjsjohnmurray
Copy link
Contributor

Maybe related to #217140

@sandy081
Copy link
Member

I also see the the error in the console, but the extension seems to run fine. @jrieken Is it the same for you? Is the extension running fine? Is there anything broken?

@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions labels Jun 25, 2024
@sandy081 sandy081 added this to the June 2024 milestone Jun 25, 2024
@jrieken
Copy link
Member Author

jrieken commented Jun 25, 2024

No, it's not broken. This message is printed when proposal names from an extension don't existing according to the product. I guess the bug is that some check doesn't strip the @2 part

sandy081 added a commit that referenced this issue Jun 25, 2024
@sandy081
Fix #218058
e7c730a
@sandy081 sandy081 mentioned this issue Jun 25, 2024
Merged
@sandy081
Copy link
Member

Actually my existing check is wrong and lmTools functionality implemented by copilot chat should be broken. Because, my check is excluding allowed extensions for version check instead of considering them.

CC @roblourens - If your TPIs are blocked because of this, please trigger a new insider with this fix.

@sandy081 sandy081 mentioned this issue Jun 25, 2024
Closed
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders labels Jun 25, 2024
@sandy081 sandy081 reopened this Jun 25, 2024
@VSCodeTriageBot VSCodeTriageBot removed the unreleased Patch has not yet been released in VS Code Insiders label Jun 25, 2024
@sandy081
Copy link
Member

Previous fix is not good enough. Hence preparing better fix.

sandy081 added a commit that referenced this issue Jun 25, 2024
@sandy081
proper fix for #218058
b3fd0c5
@sandy081 sandy081 mentioned this issue Jun 25, 2024
Merged
sandy081 added a commit that referenced this issue Jun 25, 2024
@sandy081
proper fix for #218058 (#218200)
393e122
bricefriha pushed a commit to bricefriha/vscode that referenced this issue Jun 26, 2024
@sandy081 @bricefriha
Fix microsoft#218058 (microsoft#218182)
031a098
bricefriha pushed a commit to bricefriha/vscode that referenced this issue Jun 26, 2024
@sandy081 @bricefriha
proper fix for microsoft#218058 (microsoft#218200)
87f3310
@rzhao271 rzhao271 added the verified Verification succeeded label Jun 27, 2024
aaronchucarroll pushed a commit to aaronchucarroll/vscode that referenced this issue Jul 10, 2024
@sandy081 @aaronchucarroll
Fix microsoft#218058 (microsoft#218182)
2ca7d9e
aaronchucarroll pushed a commit to aaronchucarroll/vscode that referenced this issue Jul 10, 2024
@sandy081 @aaronchucarroll
proper fix for microsoft#218058 (microsoft#218200)
34b01aa
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded
Projects
None yet
Milestone
June 2024
Development

Successfully merging a pull request may close this issue.

Fix #218058 microsoft/vscode
5 participants
@jrieken @gjsjohnmurray @rzhao271 @sandy081 @VSCodeTriageBot