Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat outline in response title is cut-off #218031

Closed
isidorn opened this issue Jun 25, 2024 · 2 comments
Closed

Chat outline in response title is cut-off #218031

isidorn opened this issue Jun 25, 2024 · 2 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug chat insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
July 2024

Comments

@isidorn
Copy link
Contributor

isidorn commented Jun 25, 2024

  1. Chat view, "What are the issues from this repo assigned to me"
  2. You get a response, click on the GitHub Copilot used ... line
  3. Outline is cut 🐛

The outline should contain the actions on the right

Image
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug chat labels Jun 28, 2024
@roblourens roblourens added this to the July 2024 milestone Jun 28, 2024
roblourens added a commit that referenced this issue Jun 28, 2024
@roblourens
Fix #218031
8d76464
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jun 28, 2024
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 3, 2024
aaronchucarroll pushed a commit to aaronchucarroll/vscode that referenced this issue Jul 10, 2024
@roblourens @aaronchucarroll
Fix microsoft#218031 (microsoft#219215)
263cad1
@isidorn
Copy link
Contributor Author

isidorn commented Jul 15, 2024

Better than before -> verified
However the outline should be 1px or 2px larger. If you zoom in you can see how the outline cuts in the gray circle around the icon.

@roblourens let me know if you want a new issue for this.

Image
Image

@isidorn isidorn added the verified Verification succeeded label Jul 15, 2024
roblourens added a commit that referenced this issue Jul 26, 2024
@roblourens
Add breathing room around the chat user focus border
a626684 
#218031
@roblourens roblourens mentioned this issue Jul 26, 2024
Merged
@roblourens
Copy link
Member

Pushing a fix for that

roblourens added a commit that referenced this issue Jul 26, 2024
@roblourens
Add breathing room around the chat user focus border (#223810)
203e283 
#218031
nagi1999a pushed a commit to nagi1999a/vscode that referenced this issue Jul 26, 2024
@roblourens
Add breathing room around the chat user focus border (microsoft#223810)
8eb2abc 
microsoft#218031
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug chat insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
July 2024
Development

No branches or pull requests
3 participants
@roblourens @isidorn @VSCodeTriageBot