Integrated terminal: sticky scroll header has wider letter spacing

[ian-h-chamberlain]

Type: Bug

Configuration using all defaults except these:

{
    // I think Monaspace makes it obvious but other fonts are also affected:
    "terminal.integrated.fontFamily": "Monaspace Argon, Input Mono, Monaco, monospace",
    "terminal.integrated.fontSize": 11,
    "terminal.integrated.fontWeight": "400",
    "terminal.integrated.fontWeightBold": "800",
    // more obvious with 1 set here, but 0 also reproduces
    "terminal.integrated.letterSpacing": 1,
}

1. Run a few commands in the integrated terminal
2. Scroll down to trigger sticky scroll

Compare the non-sticky appearance:

With the sticky appearance:

Side by side:

After experimenting a bit with the letterSpacing configuration, I suspect the sticky bar is rendered with a spacing terminal.integrated.letterSpacing + 1 - it always seems to be wider spacing than the rest of the terminal.

---

VS Code version: Code - Insiders 1.91.0-insider (63d0666, 2024-06-21T10:24:54.816Z)
OS version: Darwin x64 23.5.0
Modes:

System Info

Item	Value
CPUs	Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz (16 x 2300)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_graphite: disabled_off video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled webgpu: enabled
Load (avg)	3, 4, 5
Memory (System)	32.00GB (2.97GB free)
Process Argv	--disable-extensions --crash-reporter-id 58c9d45f-6b80-48d3-8c0b-d09f8a479b86
Screen Reader	no
VM	0%

Extensions disabled

A/B Experiments

vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805cf:30301675
vsaa593cf:30376535
py29gd2263:31024238
c4g48928:30535728
vscrpc:30624061
2i9eh265:30646982
962ge761:30841072
pythongtdpath:30726887
welcomedialog:30812478
pythonnoceb:30776497
asynctok:30898717
dsvsc013:30777762
dsvsc014:30777825
dsvsc015:30821418
pythonregdiag2:30926734
pythonmypyd1:30859725
2e7ec940:31000449
pythontbext0:30879054
accentitlementst:30870582
dsvsc016:30879898
dsvsc017:30880771
dsvsc018:30880772
cppperfnew:30980852
pythonait:30973460
jchc7451:31067543
showvideot:31016890
chatpanelt:31014475
01bff139:31013167
a69g1124:31018687
dvdeprecation:31040973
dwnewjupytercf:31046870
impr_priority:31057980
nativerepl1:31071684

[Tyriar]

This is because they use different renderers, see #218427

[L0laapk3]

Is my understanding correct that the goal is to make the sticky scroll header the same size & width as the rest of the terminal (after #218427)? Having a different width/size does not work well with stuff like ZSH right prompt.

[Tyriar]

@L0laapk3 yep, it should look exactly the same when #218941 lands