Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watcher Perf: TypeScript 5.5 asks to watch thousands of non-existing paths #214765

Closed
bpasero opened this issue Jun 10, 2024 · 0 comments
Closed

Watcher Perf: TypeScript 5.5 asks to watch thousands of non-existing paths #214765

bpasero opened this issue Jun 10, 2024 · 0 comments
Assignees
@bpasero
Labels
file-watcher File watcher insiders-released Patch has been released in VS Code Insiders
Milestone
June 2024

Comments

@bpasero
Copy link
Member

bpasero commented Jun 10, 2024

With TS 5.5 we are seeing a lot more requests to watch paths such as src/vs/platform/dialogs/package.json which in the end makes the file watcher consume 100% CPU for at least a minute on my machine.

Need to understand why this is so slow on startup, probably some n^2 complexity somewhere trying to handle these requests.
@bpasero bpasero added freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues file-watcher File watcher performance labels Jun 10, 2024
@bpasero bpasero added this to the June 2024 milestone Jun 10, 2024
@bpasero bpasero self-assigned this Jun 10, 2024
@bpasero bpasero removed freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues performance labels Jun 10, 2024
bpasero added a commit that referenced this issue Jun 11, 2024
@bpasero
Watcher Perf: TypeScript 5.5 asks to watch thousands of non-existing …
9c92f1f 
…paths (fix #214765)
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jun 11, 2024
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bpasero bpasero

Labels
file-watcher File watcher insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
June 2024
Development

No branches or pull requests
2 participants
@bpasero @VSCodeTriageBot