Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I used to be able to click links on integrated terminal by holding the Alt key. Now, without any action on my part (I haven't even update it), it changes to some useless cross symbol. #199848

Closed
KSXGitHub opened this issue Dec 2, 2023 · 11 comments · Fixed by #201324
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-links verified Verification succeeded

Comments

@KSXGitHub
Copy link

No description provided.

@IllusionMH
Copy link
Contributor

/gifPlease

@VSCodeTriageBot
Copy link
Collaborator

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.

If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.

Happy coding!

@VSCodeTriageBot VSCodeTriageBot added the info-needed Issue requires more information from poster label Dec 2, 2023
@meganrogge meganrogge added terminal-links and removed info-needed Issue requires more information from poster labels Dec 4, 2023
@meganrogge meganrogge assigned Tyriar and unassigned meganrogge Dec 4, 2023
@Tyriar
Copy link
Member

Tyriar commented Dec 8, 2023

The terminal's usage of editor.multiCursorModifier may have regressed?

@Tyriar Tyriar added this to the December / January 2024 milestone Dec 8, 2023
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug and removed confirmation-pending labels Dec 20, 2023
@Tyriar
Copy link
Member

Tyriar commented Dec 20, 2023

The issue I'm seeing is editor.multiCursorModifier no longer seems to flip the terminal link modifiers and column select modifier. Additionally the + cursor isn't showing anymore when using column selection.

Tyriar added a commit to Tyriar/xterm.js that referenced this issue Dec 20, 2023
This was not happening in the demo because the xterm instance is almost
always focused.

See microsoft/vscode#199848
@Tyriar
Copy link
Member

Tyriar commented Dec 20, 2023

Actually I don't think it ever flipped the column select modifier

@Tyriar
Copy link
Member

Tyriar commented Dec 20, 2023

When "editor.multiCursorModifier": "ctrlCmd" is set, alt+click still opens fine. After xtermjs/xterm.js#4921 the crosshair will be working as intended, the link pointer cursor will override it correctly.

Tyriar added a commit that referenced this issue Dec 20, 2023
@Tyriar Tyriar mentioned this issue Dec 20, 2023
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Dec 20, 2023
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 3, 2024
@alexr00
Copy link
Member

alexr00 commented Jan 25, 2024

Recording 2024-01-25 at 11 49 19

I can still repro if "editor.multiCursorModifier": "alt". Is there something else I should set? It works fine if I set "editor.multiCursorModifier": "ctrlCmd".

@alexr00 alexr00 added the verification-steps-needed Steps to verify are needed for verification label Jan 25, 2024
@aiday-mar
Copy link
Contributor

Since verification steps are needed and @Tyriar is OOF, this issue will be moved to the February 2024 milestone.

@aiday-mar aiday-mar modified the milestones: December / January 2024, February 2024 Jan 26, 2024
@alexr00
Copy link
Member

alexr00 commented Jan 26, 2024

@meganrogge in case you know the verifications steps.

@meganrogge
Copy link
Contributor

I verified that regardless of the value of editor.multiCursorModifier, I can open links in the terminal with ctrlCmd and holding alt allows me to do column selection, which I believe is by design.

@meganrogge meganrogge added verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Jan 26, 2024
@meganrogge meganrogge modified the milestones: February 2024, December / January 2024 Jan 26, 2024
@KSXGitHub
Copy link
Author

It turns out that the bug has nothing to do with the cross cursor. The real cause was extension host keep crashing after a few minutes after opening a big TypeScript monorepo.

@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-links verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants