Unexpected context menu

[jrieken]

Testing #193991

• disable editor tabs
• select the ... overflow menu
• it contains two configuration command (enable tabs, preview editors)
• enable tabs
• those (or related) config commands show in the context menu of the title area blank which I would also expect for non tabs.

[bpasero]

@jrieken I think the main difference is that when tabs are disabled, we basically treat the entire title area like a very wide single tab (it even has the X close button at the end like a tab):

As such, there is no real "empty space" when tabs are disabled because all space is the tab. We can only show those other actions in the "..." menu.

[jrieken]

Yeah, but IMO it is still more natural to right-click into that area for similar commands (instead of having them overflow). Also in the menu are some pane management actions, like Split Up/Down/..., already present

[bpasero]

I don't have strong feelings where these commands appear, I think they are both "wrong" in the tab context menu and wrong in the "..." menu. We are essentially missing the context menu for the tab stripe.

The reason I went with the "..." menu is mainly to keep the already huge tabs menu shorter.

[bpasero]

One idea would be to simply not show them when tabs are disabled 🤷 . The one for pinned tabs on separate row does not work without tabs enabled anyway.

[jrieken]

Also fine for me