Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve terminal action hover UI #180739

Closed
Tracked by #20822
karrtikr opened this issue Apr 24, 2023 · 5 comments
Closed
Tracked by #20822

Improve terminal action hover UI #180739

karrtikr opened this issue Apr 24, 2023 · 5 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal Integrated terminal issues ux User experience issues

Comments

@karrtikr
Copy link
Contributor

karrtikr commented Apr 24, 2023

  1. Improve description when only one terminal is opened:

    image

    Ideally it should be the same as:

image

@karrtikr
Copy link
Contributor Author

karrtikr commented Apr 24, 2023

  1. We should probably use markdown backticks for process description:

image

@karrtikr
Copy link
Contributor Author

karrtikr commented Apr 25, 2023

  1. Originally posted by @amunger in terminal warning actions cannot be selected if only one terminal is open vscode-python#21129 (comment)

    also you can tell that I struggled a bit to actually click the actions in the dialog

    terminalWarnings

@karrtikr karrtikr changed the title Improve shell integration hover description when only one terminal is opened Improve shell integration hover UI Apr 25, 2023
@karrtikr karrtikr changed the title Improve shell integration hover UI Improve terminal action hover UI Apr 25, 2023
@Tyriar
Copy link
Member

Tyriar commented May 12, 2023

1 Improve description when only one terminal is opened:

#177774

2 We should probably use markdown backticks for process description:

It was originally styled like that but it was much too large and less readable considering the default shell integration injection command line.

also you can tell that I struggled a bit to actually click the actions in the dialog

#162336

@Tyriar Tyriar closed this as completed May 12, 2023
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label May 12, 2023
@karrtikr
Copy link
Contributor Author

It was originally styled like that but it was much too large and less readable considering the default shell integration injection command line.

Maybe not for the whole command line but atleast for the file paths I think using backticks makes it more readable.

@Tyriar
Copy link
Member

Tyriar commented May 12, 2023

Args could be paths too though and the default Windows profile can be really huge:

image

@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2023
@karrtikr karrtikr closed this as not planned Won't fix, can't repro, duplicate, stale Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal Integrated terminal issues ux User experience issues
Projects
None yet
Development

No branches or pull requests

2 participants