Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility:MAS42A: More colors in high contrast theme #17178

Closed
WiproPSAccTest opened this issue Dec 14, 2016 · 4 comments
Closed

Accessibility:MAS42A: More colors in high contrast theme #17178

WiproPSAccTest opened this issue Dec 14, 2016 · 4 comments
Assignees
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded windows VS Code on Windows issues
Milestone

Comments

@WiproPSAccTest
Copy link

VS Code Version:1.6.1
OS Version:1607
Pre-Requisite:
1.Open visual studio code editor.
2.Using "Ctrl+Shift+P" key Open the command Pallete.
3.Type Theme, Navigate to Preferences: Color Theme and Hit Enter.
4.Navigate to High Contrast and Hit Enter

Steps to Reproduce:
1.Open visual studio code editor.
2. Using "Ctrl+Shift+E", key navigate to the Explorer button.
3. Using Tab Arrive at "Open folder" and Hit Enter.
4. Select the Node Modules folder from your Computer.
5. Using Tab, Navigate to a file you want to view and Hit Enter.
6. Visually observe the how Variables, Functions, Modules, Loop Statements , Exceptions, function Names and Variables Names etc are differentiated in High Contrast Theme.

Expected Result:
There should be visual Color Differentiation between Functions and Loops Statements or Exceptions of code snippets in High Contrast Theme.
Actual Result:
High Contrast Theme:

  1. All Functions, Loops, Modules, Exceptions are defined in Blue color in High Contrast.
  2. All Variable Names, Functions Names are White in Color in High Contrast Theme.
  3. Statements are defined in Bolden Orange color

Dark+(Default Dark):

  1. Functions and Modules are defined in Blue Color.
  2. Loops and Exceptions are defined in Pink Color.
  3. Variable Names are defined in Sky Blue Color.
  4. Statements are defined in Orange color
  5. Function Names are defined in Yellow Color.

User Impact:
Low Vision users will not be able easily understand the areas of code snippets without visual color differentiation.

example 1_there is no visual color differentiation between functions and loops statemens or exceptions of code snippets in high contrast theme
example 2_there is no visual color differentiation between functions and loops statemens or exceptions of code snippets in high contrast theme

@kieferrm kieferrm added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Dec 14, 2016
@aeschli aeschli changed the title Accessibility: There is no visual Color Differentiation between Functions and Loops Statemens or Exceptions of code snippets in High Contrast Theme [theme] More colors in high contrast theme Dec 31, 2016
@aeschli aeschli added themes Color theme issues feature-request Request for new features or functionality labels Dec 31, 2016
@aeschli aeschli added this to the Backlog milestone Dec 31, 2016
@WiproPSAccTest
Copy link
Author

For a color blindness or low vision people color differentiation should be present. color differentiation makes it easy for them to differentiate different areas of the code.

@WiproPSAccTest WiproPSAccTest changed the title [theme] More colors in high contrast theme Accessibility:MAS42A: More colors in high contrast theme Feb 1, 2017
@WiproPSAccTest
Copy link
Author

Title has been changed to a common format to perform data population.

@isidorn
Copy link
Contributor

isidorn commented May 17, 2017

I can look into this. Assigning to me

@isidorn isidorn assigned isidorn and unassigned aeschli May 17, 2017
@isidorn isidorn modified the milestones: May 2017, Backlog May 17, 2017
@isidorn isidorn added the verification-needed Verification of issue is requested label May 18, 2017
@isidorn
Copy link
Contributor

isidorn commented May 18, 2017

Now we are using all the dark+ token colors in high contrast theme

aeschli added a commit that referenced this issue May 18, 2017
@Lixire Lixire added the verified Verification succeeded label May 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
@chrmarti chrmarti added the a11ymas Issue from accessibility team label Oct 3, 2018
@isidorn isidorn added the windows VS Code on Windows issues label Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

7 participants