Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiles: Export when Show Profile Contents view is open doesn't bring up quick pick #170736

Closed
chrisdias opened this issue Jan 7, 2023 · 6 comments · Fixed by #171492
Closed
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue user-profiles User profile management
Milestone

Comments

@chrisdias
Copy link
Member

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version:
Version: 1.75.0-insider
Commit: 727d2d32aea02baf7d13fa38787e8ed64dd858d0
Date: 2023-01-06T05:21:04.561Z
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Darwin x64 20.6.0
Sandboxed: Yes
  • OS Version:
    MacOS Big Sur latest

Steps to Reproduce:

  • Create a new profile
  • Click on the Profile Activity Bar icon, then choose Export Profile...

Result: the quick pick comes up...

image

  • Now click on the Show Profile Contents menu item to bring up the view
  • Click on the Export Profile... menu item again

Result: focus just moves to the Show Profile Contents pane

image

Expectation: Show the Quick Pick so the menu works the same regardless of whether or not the content view is open

@isidorn
Copy link
Contributor

isidorn commented Jan 9, 2023

I was also hit by this - that by clicking on "Export Profile..." it looks like it has no effect, when it fact it just passed the focus.
@sandy081 we could always show quick pick as Chris suggests?

@sandy081
Copy link
Member

What about the contents view when you click on Export Profile... again? Does this has to be closed or remain like this? May I understand what is confusing in navigating to the contents view when you click on export profile button?

@sandy081 sandy081 added info-needed Issue requires more information from poster user-profiles User profile management labels Jan 10, 2023
@chrisdias
Copy link
Member Author

I think you can leave the view open, but I would open the Quick Pick right away, not force the user to click on the Export button (again).

@sandy081
Copy link
Member

Another idea (that was also mentioned in the UX call) is how about always open the view and ditch quick pick? This was initial flow actually.

@isidorn
Copy link
Contributor

isidorn commented Jan 12, 2023

I think that flow might work. My biggest concern is that users might not notice that the focus moved to the view (especially if the view is already open). Long term - maybe the view becomes a custom editor?

fyi @daviddossett @stevencl

sandy081 added a commit that referenced this issue Jan 17, 2023
@sandy081
Copy link
Member

Quick pick is removed and by default we show the contents view now.

@sandy081 sandy081 added polish Cleanup and polish issue and removed info-needed Issue requires more information from poster labels Jan 17, 2023
@sandy081 sandy081 added this to the January 2023 milestone Jan 17, 2023
sandy081 added a commit that referenced this issue Jan 17, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue user-profiles User profile management
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants