Warning An icon requires a repository with HTTPS protocol to be specified in this package.json. on icon in package.json despite everything working correctly

[segevfiner]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.74.2
• OS Version: macOS 12.6.2

Steps to Reproduce:

1. Create an extension and specify a relative path to an icon in the package.json in png format, and specify repository as "repository": {}. (Our repository is private)
2. We get a warning An icon requires a repository with HTTPS protocol to be specified in this package.json., despite the icon showing correctly in the marketplace and the VS Code extension manager (We also have images in our README.md that we hosted externally. Our repository is private after all).

Extension: https://marketplace.visualstudio.com/items?itemName=Swimm.swimm

[maninak]

I get the same warning

despite my fields being defined as

"icon": "./assets/marketplace-icon.png",
"repository": "https://github.com/cytechmobile/radicle-vscode-extension",

Source: https://github.com/cytechmobile/radicle-vscode-extension/blob/a285b81f75c6152253114b2569e206709c1c4451/package.json#L10

Interestingly the icon shows up in the marketplace just fine.

[chrmarti]

@joaomoreno I see the icon is served from the CDN now and we can remove the warning about the relative icon path. What about badges in the package.json and images in the README markdown, are these also served from CDN?

[joaomoreno]

Those are all served from the raw GitHub routes, this is why vsce needs to know what repository hosts the sources.

[segevfiner]

But the icon isn't, not anymore at least... Our repo is private, the icon works just fine and is uploaded along with the vsix and hosted in some CDN. Images in the readme are indeed served directly so will require this check or an absolute URLs.

[joaomoreno]

Ah! This is just the workbench linter. I also forgot that we actually show the icons served directly from the MP, not GH. Sorry about the confusion, thanks for following up @segevfiner.

@chrmarti This warning is unnecessary by now, let's remove it.