[Perf] Use IConfigurationChangeEvent#affectsConfiguration

[jrieken]

related #168639

The configuration service encapsulates all our configuration settings (~750 keys) and its event fires whenever any of them change. Naturally this service has many listener. This combination means all listeners should be conservative and avoid unnecessary work, e.g a listener that's interested in the foo.bar setting shouldn't do something when the bazz.bazz setting changes. For that the IConfigurationChangeEvent#affectsConfiguration-util exists. It allows to quickly check if an event affects "your" setting, this is a good sample of being conservative.

The following list (is hopefully complete) and all listeners that unconditionally do work when any configuration changes. This is wasteful and esp hurtful during startup (when all settings are registered)

---

• src/vs/platform/list/browser/listService.ts @joaomoreno

  • 686, 49: configurationService.onDidChangeConfiguration(() => {

• src/vs/platform/quickinput/browser/commandsQuickAccess.ts @bpasero

  • 221, 44: configurationService.onDidChangeConfiguration(() => this.updateConfiguration()));

• src/vs/platform/request/node/requestService.ts @sandy081

  • 56, 39: configurationService.onDidChangeConfiguration(() => this.configure(configurationService.getValue()), this));

• src/vs/platform/telemetry/common/telemetryService.ts @lramos15

  • 68, 30: _configurationService.onDidChangeConfiguration(this._updateTelemetryLevel, this, this._disposables);

• src/vs/platform/telemetry/common/telemetryUtils.ts @lramos15

  • 94, 30: configurationService.onDidChangeConfiguration(event => {

• src/vs/platform/windows/electron-main/windowImpl.ts @chrmarti @sbatten

  • 619, 44: configurationService.onDidChangeConfiguration(e => this.onConfigurationUpdated(e)));

• src/vs/workbench/browser/layout.ts @sbatten

  • 277, 44: configurationService.onDidChangeConfiguration(() => this.doUpdateLayoutConfiguration()));

• src/vs/workbench/browser/workbench.ts @bpasero

  • 227, 39: configurationService.onDidChangeConfiguration(() => this.setFontAliasing(configurationService)));

• src/vs/workbench/common/editor/editorGroupModel.ts @bpasero

  • 210, 44: configurationService.onDidChangeConfiguration(() => this.onConfigurationUpdated()));

• src/vs/workbench/contrib/localHistory/browser/localHistoryTimeline.ts @bpasero

  • 88, 44: configurationService.onDidChangeConfiguration(e => {

• src/vs/workbench/contrib/markers/browser/markersFileDecorations.ts @sandy081

  • 69, 31: _configurationService.onDidChangeConfiguration(this._updateEnablement, this),

• src/vs/workbench/contrib/mergeEditor/browser/model/diffComputer.ts @hediet

  • 25, 29: configurationService.onDidChangeConfiguration,

• src/vs/workbench/contrib/mergeEditor/browser/view/editors/codeEditorView.ts @hediet

  • 63, 29: configurationService.onDidChangeConfiguration,
    68, 29: configurationService.onDidChangeConfiguration,
    73, 29: configurationService.onDidChangeConfiguration,

• src/vs/workbench/contrib/mergeEditor/browser/view/mergeEditor.ts @hediet

  • 102, 29: configurationService.onDidChangeConfiguration,

• src/vs/workbench/contrib/mergeEditor/browser/view/viewModel.ts @hediet

  • 89, 29: configurationService.onDidChangeConfiguration,

• src/vs/workbench/contrib/relauncher/browser/relauncher.contribution.ts @bpasero

  • 60, 44: configurationService.onDidChangeConfiguration(e => this.onConfigurationChange(this.configurationService.getValue(), e)));

• src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts @meganrogge

  • 287, 45: _configurationService.onDidChangeConfiguration(() => {

• src/vs/workbench/contrib/testing/browser/testingExplorerView.ts @connor4312

  • 570, 39: configurationService.onDidChangeConfiguration(() => {
    575, 39: configurationService.onDidChangeConfiguration(() => {

• src/vs/workbench/contrib/welcomeWalkthrough/browser/walkThroughPart.ts @bhavyaus

  • 358, 61: configurationService.onDidChangeConfiguration(() => {

• src/vs/workbench/services/editor/browser/editorService.ts @bpasero

  • 102, 44: configurationService.onDidChangeConfiguration(e => this.onConfigurationUpdated(this.configurationService.getValue())));

[lramos15]

telemetryUtils.ts must remain an unconditional listener because it records anytime the settings change to gain a better understanding of what settings user's are adjusting.

[jrieken]

@lramos15 makes sense but you could debounce it and merge the listening since you being called repeated during startup

[bpasero]

Noticed the configuration listener in editor to be quite expensive, blocking startup:

Refs:

vscode/src/vs/editor/common/services/modelService.ts

Line 176 in eaa9b1b

this._register(this._configurationService.onDidChangeConfiguration(() => this._updateModelOptions()));

[bpasero]

Ping to remaining owners @sbatten @hediet @chrmarti @meganrogge

[bpasero]

Noticed a few more, because ITextResourceConfigurationService wraps around IConfigurationService and thus was not part of the list above: #170975