Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build[macos]: Upload configuration (for Bing settings search) timeout #149089

Closed
deepak1556 opened this issue May 9, 2022 · 9 comments · Fixed by #149203
Closed

build[macos]: Upload configuration (for Bing settings search) timeout #149089

deepak1556 opened this issue May 9, 2022 · 9 comments · Fixed by #149203
Assignees
Labels
candidate Issue identified as probable candidate for fixing in the next release debt Code quality issues engineering VS Code - Build / issue tracking / etc. macos Issues with VS Code on MAC/OS X verified Verification succeeded

Comments

@deepak1556
Copy link
Collaborator

@deepak1556 deepak1556 added macos Issues with VS Code on MAC/OS X engineering VS Code - Build / issue tracking / etc. labels May 9, 2022
@roblourens
Copy link
Member

Not sure what's going on - this process is pretty straightforward and hasn't changed in years.

I am launching the full vscode window on this build machine, nothing has changed in electron that would interact with that right?

@roblourens roblourens added the debt Code quality issues label May 9, 2022
@deepak1556
Copy link
Collaborator Author

main and release/1.67 are on same electron versions, the step worked fine in the release/1.67 latest build last Friday https://dev.azure.com/monacotools/Monaco/_build/results?buildId=170088&view=results, first timeout failure started since insiders were turned back on main last Saturday https://dev.azure.com/monacotools/Monaco/_build/results?buildId=170136&view=results and since then all insiders build seem to consistently hit the timeout

Todays' nightly run: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=170422&view=logs&j=3792f238-f35e-5f82-0dbc-272432d9a0fb&t=0d7e5bc9-922f-51dd-b06a-a90d0b9feeeb

Error: export-default-configuration process timed out
    at Timeout._onTimeout (/Users/runner/work/1/s/build/azure-pipelines/upload-configuration.js:54:20)
    at listOnTimeout (node:internal/timers:559:17)
    at processTimers (node:internal/timers:502:7)

Testing if I can repro the issue locally.

@deepak1556
Copy link
Collaborator Author

Testing the callsite

`${appPath} --export-default-configuration='${result}' --wait --user-data-dir='${userDataDir}' --extensions-dir='${extensionsDir}'`,
locally seems to work fine.

@deepak1556
Copy link
Collaborator Author

I wonder if the timeout is insufficient, testing a build with increased timeout here https://monacotools.visualstudio.com/Monaco/_build/results?buildId=170440&view=results

@deepak1556
Copy link
Collaborator Author

Previous build did not enable the upload step, new build https://monacotools.visualstudio.com/Monaco/_build/results?buildId=170483&view=results

@roblourens
Copy link
Member

Kicked off another, removing the branch check

@roblourens roblourens added this to the May 2022 milestone May 10, 2022
@hediet hediet reopened this May 15, 2022
@vscodenpa vscodenpa removed the insiders-released Patch has been released in VS Code Insiders label May 15, 2022
@hediet hediet closed this as completed May 15, 2022
@hediet
Copy link
Member

hediet commented May 15, 2022

Might not be fixed (https://dev.azure.com/monacotools/Monaco/_build/results?buildId=170713&view=results - run on 11th of May, one day after this fix has been merged to main)

@deepak1556
Copy link
Collaborator Author

deepak1556 commented May 16, 2022

@hediet the fix only landed in main, failing build was on release/1.67, @roblourens how do you feel about backporting the fix to release/1.67 ?

@roblourens
Copy link
Member

I can do that

@roblourens roblourens reopened this May 16, 2022
@roblourens roblourens added the candidate Issue identified as probable candidate for fixing in the next release label May 16, 2022
@joyceerhl joyceerhl added the verified Verification succeeded label May 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
candidate Issue identified as probable candidate for fixing in the next release debt Code quality issues engineering VS Code - Build / issue tracking / etc. macos Issues with VS Code on MAC/OS X verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@roblourens @deepak1556 @hediet @joyceerhl @vscodenpa and others